Ticket #85 (new defect)

Opened 2 months ago

httpcli2 fixes

Reported by: tmm1 Assigned to: raggi
Priority: major Milestone: EventMachine "Framework"
Keywords: Cc:

Description

debugging:

commit 792431ffc0d1e6a647dbda78ef68f1c7af565d92
Author: Aman Gupta <aman@tmm1.net>
Date:   Tue Oct 7 16:07:12 2008 -0700

    turn off debugging

diff --git a/lib/protocols/httpcli2.rb b/lib/protocols/httpcli2.rb
index 232c3d3..cda359b 100644
--- a/lib/protocols/httpcli2.rb
+++ b/lib/protocols/httpcli2.rb
@@ -134,7 +134,7 @@ module Protocols
                                        end
                                else
                                        # We correctly come here after each chunk gets read.
-                                       p "Got A BLANK chunk line"
+                                       # p "Got A BLANK chunk line"
                                end
 
                        end
@@ -144,7 +144,7 @@ module Protocols
                        # We get a single chunk. Append it to the incoming content and switch back to line mode.
                        #
                        def receive_chunked_text text
-                               p "RECEIVED #{text.length} CHUNK"
+                               # p "RECEIVED #{text.length} CHUNK"
                                (@content ||= []) << text
                        end
 

content is nil:

commit f8fa24767b98393b036d3c51e3784cb348030e2e
Author: Aman Gupta <aman@tmm1.net>
Date:   Tue Oct 7 16:07:06 2008 -0700

    handle @content is nil

diff --git a/lib/protocols/httpcli2.rb b/lib/protocols/httpcli2.rb
index 518c5bf..232c3d3 100644
--- a/lib/protocols/httpcli2.rb
+++ b/lib/protocols/httpcli2.rb
@@ -129,7 +129,7 @@ module Protocols
                                        if chunksize > 0
                                                @conn.set_text_mode(ln.to_i(16))
                                        else
-                                               @content = @content.join
+                                               @content = @content ? @content.join : ''
                                                @chunk_trailer = true
                                        end
                                else